Clean up resolve_supported_languages_using_cli FF
#3224
+63
−156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrymercer
force-pushed
the
henrymercer/clean-up-resolve-languages-ff
branch
from
5afb9b9 to
a691497
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR removes the resolve_supported_languages_using_cli feature flag and its associated infrastructure, as it has been successfully rolled out and is no longer needed. The change simplifies the codebase by replacing feature flag checks with direct calls to codeql.supportsFeature() to determine if the CLI supports the BuiltinExtractorsSpecifyDefaultQueries tools feature.
Key Changes
- Removed the
ResolveSupportedLanguagesUsingClifeature flag enum value and configuration - Updated
getSupportedLanguageMap()to check for CLI support directly instead of using the feature flag - Removed the
featuresparameter fromgetLanguages()andinitActionState()functions - Simplified test cases by removing the feature flag variations
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/feature-flags.ts | Removed ResolveSupportedLanguagesUsingCli feature flag definition and configuration |
| src/config-utils.ts | Replaced feature flag check with direct CLI feature support check and removed features parameter |
| src/config-utils.test.ts | Removed test iterations for feature flag variations, keeping only the enabled behavior |
| lib/*.js | Generated JavaScript code reflecting the TypeScript changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up this FF now it has been successfully rolled out.
Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
analysis-kinds: code-scanning).analysis-kinds: code-quality).How did/will you validate this change?
.test.tsfiles).pr-checks).If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Merge / deployment checklist